lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <48CC10B7.30504@garzik.org>
Date:	Sat, 13 Sep 2008 15:12:55 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Magnus Damm <magnus.damm@...il.com>
CC:	netdev@...r.kernel.org, eric.miao@...vell.com, nico@....org
Subject: Re: [PATCH] smc91x: fix nowait printout

Magnus Damm wrote:
> From: Magnus Damm <damm@...l.co.jp>
> 
> Commit c4f0e76747e80578a8f7fddd82fd0ce8127bd2f8 added nowait platform
> data support. The printout code was however not updated, so the value
> of SMC_NOWAIT is still used. This patch makes sure that nowait is printed
> accordingly to platform data.
> 
> Signed-off-by: Magnus Damm <damm@...l.co.jp>
> ---
> 
>  drivers/net/smc91x.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- 0001/drivers/net/smc91x.c
> +++ work/drivers/net/smc91x.c	2008-09-03 18:42:56.000000000 +0900
> @@ -1961,7 +1961,8 @@ static int __init smc_probe(struct net_d
>  		if (dev->dma != (unsigned char)-1)
>  			printk(" DMA %d", dev->dma);
>  
> -		printk("%s%s\n", nowait ? " [nowait]" : "",
> +		printk("%s%s\n",
> +			lp->cfg.flags & SMC91X_NOWAIT ? " [nowait]" : "",
>  			THROTTLE_TX_PKTS ? " [throttle_tx]" : "");

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ