netdev - Re: [patch for 2.6.27? 4/4] e1000e: prevent corruption of EEPROM/NVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48CC1136.2090005@garzik.org>
Date:	Sat, 13 Sep 2008 15:15:02 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
CC:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	chrisl@...are.com, arvidjaar@...l.ru,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	pratap@...are.com, zach@...are.com
Subject: Re: [patch for 2.6.27? 4/4] e1000e: prevent corruption of EEPROM/NVM

Brandeburg, Jesse wrote:
> akpm@...ux-foundation.org wrote:
>> From: Christopher Li <chrisl@...are.com>
>>
>> Andrey reports e1000e corruption, and that a patch in vmware's ESX
>> fixed 
>> it.
>>
>> The EEPROM corruption is triggered by concurrent access of the EEPROM
>> read/write. Putting a lock around it solve the problem.
>>
> 
> NAK.  Please do not apply this patch, for reasons mentioned in my other
> reply just sent to netdev.
> 
> The RTNL should be preventing this from being a possible bug in *Linux*
> and if it is not we have much larger problems, not the least of which is
> that this patch doesn't lock against the driver accessing the eeprom
> simultaneously.

Ping.  A problem still occurs, regardless of what should be prevented?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html