netdev - Re: [PATCH 2.6.28 1/4] myri10ge: Stop scaring people when DCA is built but absent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48CC14CE.4050904@garzik.org>
Date:	Sat, 13 Sep 2008 15:30:22 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Brice Goglin <brice@...i.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.28 1/4] myri10ge: Stop scaring people when DCA is
 built but absent

Brice Goglin wrote:
> Stop scaring people with what looks like a fatal message when DCA support
> is compiled into their kernel, but the DCA device is not present.
> 
> Signed-off-by: Brice Goglin <brice@...i.com>
> ---
>  drivers/net/myri10ge/myri10ge.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6.git/drivers/net/myri10ge/myri10ge.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/net/myri10ge/myri10ge.c	2008-08-29 07:29:45.000000000 +0200
> +++ linux-2.6.git/drivers/net/myri10ge/myri10ge.c	2008-09-12 19:22:37.000000000 +0200
> @@ -1060,8 +1060,9 @@
>  	}
>  	err = dca_add_requester(&pdev->dev);
>  	if (err) {
> -		dev_err(&pdev->dev,
> -			"dca_add_requester() failed, err=%d\n", err);
> +		if (err != -ENODEV)
> +			dev_err(&pdev->dev,
> +				"dca_add_requester() failed, err=%d\n", err);
>  		return;

applied 1-4


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html