netdev - Re: [Fwd: [PATCH] Spinlock initialisation au1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48CC1AB4.6020200@pobox.com>
Date:	Sat, 13 Sep 2008 15:55:32 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Martin Gebert <martin.gebert@...ha-bit.de>
CC:	netdev@...r.kernel.org
Subject: Re: [Fwd: [PATCH] Spinlock initialisation au1000_eth.c]

Martin Gebert wrote:
> Seems like the spinlock for the AU1x00 ethernet device is initialised too
> late, as it is already used in enable_mac(), which is called via
> mii_probe() before the init takes place.
> The attached patch is working here for a Linux Au1100 2.6.22.6 kernel,
> and as far as I checked should also be applicable to the current head
> (just line numbers differ).
> 
> Signed-off-by: Martin Gebert <Martin.Gebert@...ha-bit.de>
> 
> --- drivers/net/au1000_eth.c    2008-06-26 14:21:53.000000000 +0200
> +++ drivers/net/au1000_eth.c    2008-06-26 14:23:00.000000000 +0200
> @@ -656,6 +656,7 @@
>         dev->name, base, irq);
> 
>     aup = dev->priv;
> +    spin_lock_init(&aup->lock);
> 
>     /* Allocate the data buffers */
>     /* Snooping works fine with eth on all au1xxx */
> @@ -766,7 +767,6 @@
>         aup->tx_db_inuse[i] = pDB;
>     }
> 
> -    spin_lock_init(&aup->lock);
>     dev->base_addr = base;
>     dev->irq = irq;

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html