netdev - Re: [PATCH] cs89x0: fix warning release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48CC1AE4.60205@garzik.org>
Date:	Sat, 13 Sep 2008 15:56:20 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] cs89x0: fix warning release_irq label

Yoichi Yuasa wrote:
> release_irq label is only used when ALLOW_DMA is defined.
> 
> drivers/net/cs89x0.c: In function 'net_open':
> drivers/net/cs89x0.c:1401: warning: label 'release_irq' defined but not used
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
> 
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/net/cs89x0.c linux/drivers/net/cs89x0.c
> --- linux-orig/drivers/net/cs89x0.c	2008-08-07 13:14:59.904521743 +0900
> +++ linux/drivers/net/cs89x0.c	2008-08-07 16:11:31.469037245 +0900
> @@ -1397,9 +1397,7 @@ net_open(struct net_device *dev)
>  release_dma:
>  #if ALLOW_DMA
>  		free_dma(dev->dma);
> -#endif
>  release_irq:
> -#if ALLOW_DMA
>  		release_dma_buff(lp);
>  #endif

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html