[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080914191135.2a28e6a6@osprey.hogchain.net>
Date: Sun, 14 Sep 2008 19:11:35 -0500
From: Jay Cliburn <jacliburn@...lsouth.net>
To: David Miller <davem@...emloft.net>
Cc: adobriyan@...il.com, csnook@...hat.com, netdev@...r.kernel.org
Subject: Re: atl1: WARNING at net/sched/sch_generic.c:221
On Sun, 14 Sep 2008 16:56:55 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:
> From: Jay Cliburn <jacliburn@...lsouth.net>
> Date: Sun, 14 Sep 2008 14:26:54 -0500
>
> > Should a netdev driver be coded such that a watchdog transmit
> > timeout never occurs?
> >
> > [ 2086.049998] NETDEV WATCHDOG: eth0 (atl1): transmit timed out
> >
> > Or is a watchdog timeout an expected occurrence if a cable is
> > unplugged/plugged?
>
> If the cable is unplugged, netif_carrier_off() will be (or should
> be) invoked by the driver, and that cancels the watchdog timer.
Thanks, I think I found the problem. It seems to fix it for me, but
I'd like Alexey to test the patch before I submit it to mainline. He
seems to be able to hit the issue more frequently than I can.
>
> This is all from memory since I'm travelling and don't have the
> time to check this directly. You should investigate this yourself
> instead of asking me if you want a truly definitive answer :)
I've been investigating it myself in my spare time since Alexey pointed
out the problem August 21.
Happy travels.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists