netdev - Re: [PATCH 2/3] enic: add main netdev file withmoduleinfrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0809171216070.4712@palito_client100.nuovasystems.com>
Date:	Wed, 17 Sep 2008 12:17:08 -0700 (PDT)
From:	Scott Feldman <scofeldm@...co.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
cc:	Scott Feldman <scofeldm@...co.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] enic: add main netdev file withmoduleinfrastructure

On Wed, 17 Sep 2008, Ben Hutchings wrote:

> On Wed, 2008-09-17 at 11:51 -0700, Scott Feldman wrote:
>> On Wed, 17 Sep 2008, Ben Hutchings wrote:
>>
>>> On Tue, 2008-09-16 at 18:49 -0700, Scott Feldman wrote:
>>>>>> +static void enic_notify_timer(unsigned long data)
>>>>>> +{
>>>>>> +	struct enic *enic = (struct enic *)data;
>>>>>> +
>>>>>> +	enic_notify_check(enic);
>>>>>> +
>>>>>> +	mod_timer(&enic->notify_timer, round_jiffies(ENIC_NOTIFY_TIMER_PERIOD));
>>>>>
>>>>> You want round_jiffies_relative() not round_jiffies().
>>>>
>>>> No, I want round_jiffies().
>>> [...]
>>>
>>> The kernel-doc says:
>>> "round_jiffies() rounds an absolute time in the future (in jiffies)
>>> up or down to (approximately) full seconds. This is useful for timers
>>> for which the exact time they fire does not matter too much, as long as
>>> they fire approximately every X seconds."
>>>
>>> You're passing in ENIC_NOTIFY_TIMER_PERIOD which is a relative time.
>>
>> I tried both and round_jiffies(2) gave the desired result of calling the timer
>> every two seconds.  Using round_jiffies_relative(2) called the timer
>> continuously.
>
> Sorry, yes, round_jiffies_relative() not only takes but also returns a
> relative time - which if interpreted as absolute is always in the past.
> So calling round_jiffies() is right, but the argument should be jiffies
> + ENIC_NOTIFY_TIMER_PERIOD.

Indeed, I'll make that change to add in jiffies.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html