netdev - Re: [RFC PATCH v6 00/16] Labeled networking patches for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48D08119.9050009@schaufler-ca.com>
Date:	Tue, 16 Sep 2008 21:01:29 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Paul Moore <paul.moore@...com>
CC:	selinux@...ho.nsa.gov, linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH v6 00/16] Labeled networking patches for 2.6.28

Paul Moore wrote:
> On Tuesday 16 September 2008 8:55:48 am Paul Moore wrote:
>   
>> Another revision to the patchset to fix two issues, one trivial, the
>> other not so much.  The trivial fix was to add some locking around
>> the connection labeling operations, we're messing with the socket so
>> we should make sure we lock it like we do everywhere else.  The
>> second fix was to ensure that we sync up a stream socket's MSS value
>> when we add IP options to the socket. We were doing everything
>> correctly on the client side, but the server side was a bit of a
>> mess; I'm pretty happy with this fix as I think it actually makes the
>> code a bit cleaner in some respects and I believe actually shrinks
>> the size of the diff slightly (a good sign).
>>
>> A special thanks to Joe Nall and John Wiseman for helping debug the
>> MSS problem.
>>
>> I've updated both the git trees earlier today so hopefully the next
>> cut of the linux-next tree should have the latest bits.
>>
>>  * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing
>>     
>
> I forgot to add, there is also a small fix to the 
> cipso_v4_sock_delattr() function so that it correctly removes the CIPSO 
> option and either adjust the option padding correctly or removes the 
> options struct entirely from the socket if it is no longer needed.
>
> Thanks to Casey Schaufler for finding this bug

Testing in progress. Thank you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html