netdev - Re: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver single patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48D27D59.4020105@garzik.org>
Date:	Thu, 18 Sep 2008 12:10:01 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Ron Mercer <ron.mercer@...gic.com>
CC:	NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver single patch

Ron Mercer wrote:
>>>From c041fd2a648cc2685b21cb7e722ba9fb05be114e Mon Sep 17 00:00:00 2001
> From: Ron Mercer <ron.mercer@...gic.com>
> Date: Tue, 16 Sep 2008 12:17:52 -0700
> Subject: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver.
> 
> 
> Signed-off-by: Ron Mercer <ron.mercer@...gic.com>
> ---
>  Documentation/networking/LICENSE.qlge |   46 +
>  MAINTAINERS                           |    7 +
>  drivers/net/Kconfig                   |    9 +
>  drivers/net/Makefile                  |    1 +
>  drivers/net/qlge/Makefile             |    7 +
>  drivers/net/qlge/qlge.h               | 1593 +++++++++++++
>  drivers/net/qlge/qlge_dbg.c           |  858 +++++++
>  drivers/net/qlge/qlge_ethtool.c       |  415 ++++
>  drivers/net/qlge/qlge_main.c          | 3954 +++++++++++++++++++++++++++++++++
>  drivers/net/qlge/qlge_mpi.c           |  150 ++
>  10 files changed, 7040 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/networking/LICENSE.qlge
>  create mode 100644 drivers/net/qlge/Makefile
>  create mode 100644 drivers/net/qlge/qlge.h
>  create mode 100644 drivers/net/qlge/qlge_dbg.c
>  create mode 100644 drivers/net/qlge/qlge_ethtool.c
>  create mode 100644 drivers/net/qlge/qlge_main.c
>  create mode 100644 drivers/net/qlge/qlge_mpi.c


applied, after fixing pci_dma_mapping_error() build breakage:  you only 
used one argument, when calling pci_dma_mapping_error().  I'm guessing 
that (a) you did not build test this on multiple platforms, both 32-bit 
and 64-bit, or (b) you are building against an older version of the kernel?

Either way, no big deal, I fixed it.  But that's something to watch for 
next time.  Your patches should always successfully build, ideally.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html