netdev - RE: [patch for 2.6.27? 3/6] e1000: prevent corruption of EEPROM/NVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36D9DB17C6DE9E40B059440DB8D95F520632F7B7@orsmsx418.amr.corp.intel.com>
Date:	Fri, 19 Sep 2008 09:20:23 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Jeff Garzik" <jeff@...zik.org>, <akpm@...ux-foundation.org>
Cc:	<netdev@...r.kernel.org>, <chrisl@...are.com>, <arvidjaar@...l.ru>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	<pratap@...are.com>, <zach@...are.com>
Subject: RE: [patch for 2.6.27? 3/6] e1000: prevent corruption of EEPROM/NVM

Jeff Garzik wrote:
> akpm@...ux-foundation.org wrote:
>> From: Christopher Li <chrisl@...are.com>
>> 
>> Andrey reports e1000 corruption, and that a patch in vmware's ESX
>> fixed it. 
>> 
>> The EEPROM corruption is triggered by concurrent access of the EEPROM
>> read/write. Putting a lock around it solve the problem.
>> 
>> [akpm@...ux-foundation.org: use DEFINE_SPINLOCK to avoid confusing
>> lockdep] Signed-off-by: Christopher Li <chrisl@...are.com>
>> Reported-by: Andrey Borzenkov <arvidjaar@...l.ru>
>> Cc: Zach Amsden <zach@...are.com>
>> Cc: Pratap Subrahmanyam <pratap@...are.com>
>> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
>> Cc: Bruce Allan <bruce.w.allan@...el.com>
>> Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
>> Cc: John Ronciak <john.ronciak@...el.com>
>> Cc: Jeff Garzik <jeff@...zik.org>
>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> ---
>> 
>>  drivers/net/e1000/e1000_hw.c |   23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
> 
> No further reply from Intel to my ping, and this regression needs to
> be addressed, so, applied.

My apologies Jeff.  I know it is late, but to close the loop, I agree
this is okay, in at least I don't believe it will harm anything, other
than adding un-necessary bloat at the worst.

Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html