netdev - Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early IRQ enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080920201839.GA27700@linux-mips.org>
Date:	Sat, 20 Sep 2008 22:18:39 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Jeff Garzik <jgarzik@...hat.com>
Cc:	Weiwei Wang <weiwei.wang@...driver.com>, linux-mips@...ux-mips.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] convert sbmac tx to spin_lock_irqsave to prevent early
	IRQ enable

On Wed, Sep 17, 2008 at 07:40:51AM -0400, Jeff Garzik wrote:

> On Wed, Sep 17, 2008 at 10:25:37AM +0800, Weiwei Wang wrote:
> > Netpoll will call the interrupt handler with interrupts
> > disabled when using kgdboe, so spin_lock_irqsave() should
> > be used instead of spin_lock_irq() to prevent interrupts
> > from being incorrectly enabled.
> > 
> > Signed-off-by: Weiwei Wang <weiwei.wang@...driver.com>
> > ---
> >  drivers/net/sb1250-mac.c |   12 +++++++-----
> >  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> Please send to jeff@...zik.org or jgarzik@...ox.com.

Jeff - I haven't looked at kgdboe but if he's right half of drivers/net
will need to be fixed ...

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html