netdev - Re: [PATCH] netdev: simple_tx_hash shouldn't hash inside fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080920.220624.177591478.davem@davemloft.net>
Date:	Sat, 20 Sep 2008 22:06:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netdev: simple_tx_hash shouldn't hash inside fragments

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Thu, 18 Sep 2008 17:43:37 -0700

> Currently simple_tx_hash is hashing inside of udp fragments.  As a result
> packets are getting getting sent to all queues when they shouldn't be.
> This causes a serious performance regression which can be seen by sending
> UDP frames larger than mtu on multiqueue devices.  This change will make
> it so that fragments are hashed only as IP datagrams w/o any protocol
> information.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>

As we discussed on IRC this fixes a pretty serious performance regression
compared to previous releases, so I added this to net-2.6 and will push
to Linus.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html