netdev - Re: [PATCH] ipvs: Restrict sync message to 255 connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080921235627.GB1342@verge.net.au>
Date:	Mon, 22 Sep 2008 09:56:28 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	Julian Anastasov <ja@....bg>,
	Wensong Zhang <wensong@...ux-vs.org>
Subject: Re: [PATCH] ipvs: Restrict sync message to 255 connections

On Fri, Sep 19, 2008 at 08:41:56PM +0200, Sven Wegener wrote:
> The nr_conns variable in the sync message header is only eight bits wide
> and will overflow on interfaces with a large MTU. As a result the backup
> won't parse all connections contained in the sync buffer. On regular
> ethernet with an MTU of 1500 this isn't a problem, because we can't
> overflow the value, but consider jumbo frames being used on a cross-over
> connection between both directors.
> 
> We now restrict the size of the sync buffer, so that we never put more
> than 255 connections into a single sync buffer.
> 
> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>

Thanks Sven, applied.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html