netdev - Re: [patch 1/8] net: fix compilation NG when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0809230846410.27041@shark.he.net>
Date:	Tue, 23 Sep 2008 08:47:59 -0700 (PDT)
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	h-shimamoto@...jp.nec.com
Subject: Re: [patch 1/8] net: fix compilation NG when !CONFIG_MODULE

On Mon, 22 Sep 2008, Andrew Morton wrote:

> On Mon, 22 Sep 2008 19:00:52 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
> 
> > From: akpm@...ux-foundation.org
> > Date: Mon, 22 Sep 2008 14:50:35 -0700
> > 
> > > From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> > > 
> > >   CC      net/core/dev.o
> > > net/core/dev.c:1001: error: redefinition of 'dev_load'
> > > include/linux/netdevice.h:1645: error: previous definition of 'dev_load' was here
> > > make[2]: *** [net/core/dev.o] Error 1
> > > 
> > > dev_load() is not used when CONFIG_MODULE disabled.
> > > 
> > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> > > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > Andrew, this problem got introduced by a tree other than networking.
> > Please push this to whatever subsystem tree added that
> > dev_load dummy decl in include/linux/netdevice.h
> > 
> > I don't see it in any trees I have here.
> 
> OK, I don't see the failure either, so I assume that whichever tree
> busted things (rusty?) was indepentently fixed.  I'll drop it, thanks.

You asked Rusty to fix it on 2008-SEP-08 here:
http://marc.info/?l=linux-kernel&m=122091240810285&w=2
and Alexey D.'s patch is here:
http://marc.info/?l=linux-netdev&m=122064308827637&w=2

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html