netdev - Re: [PATCH 2/2] netdev: docbook comment update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0809230917020.27041@shark.he.net>
Date:	Tue, 23 Sep 2008 09:19:36 -0700 (PDT)
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	"Randy.Dunlap" <rdunlap@...otime.net>
Subject: Re: [PATCH 2/2] netdev: docbook comment update

On Tue, 23 Sep 2008, Stephen Hemminger wrote:

> Add more docbook comments to network device functions and cleanup
> the comments.

Thanks!

> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> 
> --- a/net/core/dev.c	2008-09-23 08:32:48.000000000 -0700
> +++ b/net/core/dev.c	2008-09-23 08:36:09.000000000 -0700
> @@ -3322,6 +3323,12 @@ static void dev_addr_discard(struct net_
>  	netif_addr_unlock_bh(dev);
>  }
>  
> +/**
> + *	dev_get_flags - get flags reported to userspace
> + *	@dev: device
> + *
> + *	Get the combination of flag bits exported throug API's to userspace.

                                                  through
and preferably                                            APIs


> + */
>  unsigned dev_get_flags(const struct net_device *dev)
>  {
>  	unsigned flags;
> @@ -3439,6 +3461,13 @@ int dev_set_mtu(struct net_device *dev, 
>  	return err;
>  }
>  
> +/**
> + *	dev_set_mtu - Change Media Access Control Address

Wrong func name.

> + *	@dev: device
> + *	@sa: new address
> + *
> + *	Change the hardware (MAC) address of the device
> + */
>  int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa)
>  {
>  	int err;

cya,
-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html