netdev - Re: [patch 4/4] mISDN: misc timerdev fixes II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923164651.GK25711@one.firstfloor.org>
Date:	Tue, 23 Sep 2008 18:46:52 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>, kkeil@...e.de,
	netdev@...r.kernel.org, ak@...ux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes II

On Tue, Sep 23, 2008 at 11:58:44AM -0400, Christoph Hellwig wrote:
> On Tue, Sep 23, 2008 at 04:17:40PM +0200, Andi Kleen wrote:
> > > > >  static struct file_operations mISDN_fops = {
> > > > > -	.llseek		= mISDN_llseek,
> > > > 
> > > > This is wrong.  no llseek means we use default_llseek, which is
> > > > different from returning -ESPIPE.
> > > 
> > > so.. this?
> > 
> > Hmm actually on double checking it's really needed, sorry.
> 
> Yes, unfortunately the only way it's cleared currently is through using
> nonseekable_open, but I've started preparing a war plan to sort this whole
> mess out.

Yes it would be much more logical if FMODE_SEEK was cleared on character devices
by default. That is what I assumed with the original patch.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html