netdev - Re: [patch 4/4] mISDN: misc timerdev fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923104026.GA12535@infradead.org>
Date:	Tue, 23 Sep 2008 06:40:26 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	akpm@...ux-foundation.org
Cc:	kkeil@...e.de, netdev@...r.kernel.org, andi@...stfloor.org,
	ak@...ux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes

On Mon, Sep 22, 2008 at 02:51:03PM -0700, akpm@...ux-foundation.org wrote:
> From: Andi Kleen <andi@...stfloor.org>
> 
> - Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.

> -static loff_t
> -mISDN_llseek(struct file *filep, loff_t offset, int orig)
> -{
> -	return -ESPIPE;
> -}

>  static struct file_operations mISDN_fops = {
> -	.llseek		= mISDN_llseek,

This is wrong.  no llseek means we use default_llseek, which is
different from returning -ESPIPE.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html