netdev - Re: [PATCH 7/9] [ETH]: Start net device with carrier down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080924.152457.13104395.davem@davemloft.net>
Date:	Wed, 24 Sep 2008 15:24:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tpiepho@...escale.com
Cc:	netdev@...r.kernel.org, afleming@...escale.com
Subject: Re: [PATCH 7/9] [ETH]: Start net device with carrier down

From: Trent Piepho <tpiepho@...escale.com>
Date: Wed, 24 Sep 2008 14:20:55 -0700

> The problem is that when the device is first created and opened, the state
> bit indicating the carrier is down isn't set, i.e. the state is wrong.
> When the carrier comes up for the first time no netlink event is sent,
> since the device state indicated the carrier was already up.

It works properly if the device driver does as it is supposed to,
which is invoke netif_carrier_off() in it's ->open() method in this
situation.

Please fix the drivers where this is not happening.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html