netdev - Re: [PATCH] r6040: fix wrong assignment in r6040_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48DAE0B1.4000706@garzik.org>
Date:	Wed, 24 Sep 2008 20:52:01 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs

Florian Fainelli wrote:
> Hello Jeff, Francois,
> 
> This is 2.6.27 material but should be applied to your -next branch as well. Thank you.
> --
> From: Florian Fainelli <florian@...nwrt.org>
> Subject: [PATCH] r6040: fix wrong assignment in r6040_free_txbufs
> 
> This patch fixes a wrong assignment in r6040_free_txbufs
> on a receive skb pointer while we should actually do this
> on the transmit skb pointer.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
> index 396f0e4..5aff7c8 100644
> --- a/drivers/net/r6040.c
> +++ b/drivers/net/r6040.c
> @@ -261,7 +261,7 @@ static void r6040_free_txbufs(struct net_device *dev)
>  				le32_to_cpu(lp->tx_insert_ptr->buf),
>  				MAX_BUF_SIZE, PCI_DMA_TODEVICE);
>  			dev_kfree_skb(lp->tx_insert_ptr->skb_ptr);
> -			lp->rx_insert_ptr->skb_ptr = NULL;
> +			lp->tx_insert_ptr->skb_ptr = NULL;
>  		}
>  		lp->tx_insert_ptr = lp->tx_insert_ptr->vndescp;
>  	}

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html