netdev - Re: [PATCH 3/3] e1000e: remove failed request for sw/fw/hw flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0809250257070.27884@twin.jikos.cz>
Date:	Thu, 25 Sep 2008 03:00:14 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jeff Garzik <jeff@...zik.org>
cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Ingo Molnar <mingo@...e.hu>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	Bruce Allan <bruce.w.allan@...el.com>
Subject: Re: [PATCH 3/3] e1000e: remove failed request for sw/fw/hw flag

On Wed, 24 Sep 2008, Jeff Garzik wrote:

> > When the driver fails to acquire the control flag used to serialize
> > NVM and PHY accesses between the driver, firmware and hardware, remove the
> > request for the flag otherwise the hardware might grant the flag when it
> > becomes available but the driver will not release the flag.  This could
> > cause the firmware to prevent the driver getting the flag for all future
> > attempts.
> applied

BTW are you going to take the whole series, or just this fix?

I don't think that the other patches should be really applied to upstream 
(they could be very handy for debugging this horrible issue, once we could 
do any debugging of it, thoug), as they don't protect against anyone 
creating a new rw mapping, which can then be freely used to still 
overwrite the mmio area without any problems.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html