netdev - Re: [PATCH] hso for error -22 (-EINVAL) printk's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48DAF317.4040704@garzik.org>
Date:	Wed, 24 Sep 2008 22:10:31 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Denis Joseph Barrow <D.Barow@...ion.com>
CC:	Linux USB kernel mailing list <linux-usb@...r.kernel.org>,
	Linux netdev Mailing list <netdev@...r.kernel.org>
Subject: Re: [PATCH] hso for error -22 (-EINVAL) printk's

Denis Joseph Barrow wrote:
> Added check for IFF_UP in hso_resume, this should eliminate -EINVAL (-22)
> errors caused from urb's being submitted twice, once by hso_resume
> & once in hso_net_open, if suspend/resume USB power saving  mode is enabled
> Signed-off-by: Denis Joseph Barrow <D.Barow@...ion.com>
> ---
> Index: linux-2.6.27-rc6/drivers/net/usb/hso.c
> ===================================================================
> --- linux-2.6.27-rc6.orig/drivers/net/usb/hso.c	2008-09-16 16:17:11.000000000 +0200
> +++ linux-2.6.27-rc6/drivers/net/usb/hso.c	2008-09-16 16:32:05.000000000 +0200
> @@ -2606,18 +2606,21 @@
>  		if (network_table[i] &&
>  		    (network_table[i]->interface == iface)) {
>  			hso_net = dev2net(network_table[i]);
> -			/* First transmit any lingering data, then restart the
> -			 * device. */
> -			if (hso_net->skb_tx_buf) {
> -				dev_dbg(&iface->dev,
> -					"Transmitting lingering data\n");
> -				hso_net_start_xmit(hso_net->skb_tx_buf,
> -						   hso_net->net);
> -				hso_net->skb_tx_buf = NULL;
> +			if (hso_net->flags & IFF_UP) {
> +				/* First transmit any lingering data,
> +				   then restart the device. */
> +				if (hso_net->skb_tx_buf) {
> +					dev_dbg(&iface->dev,
> +						"Transmitting"
> +						" lingering data\n");
> +					hso_net_start_xmit(hso_net->skb_tx_buf,
> +							   hso_net->net);
> +					hso_net->skb_tx_buf = NULL;
> +				}
> +				result = hso_start_net_device(network_table[i]);
> +				if (result)
> +					goto out;

you should be checking netif_running() not IFF_UP


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html