netdev - Re: [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48DBC8D8.2080207@pobox.com>
Date:	Thu, 25 Sep 2008 13:22:32 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Jesse Barnes <jbarnes@...tuousgeek.org>, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org,
	Ben Hutchings <bhutchings@...arflare.com>,
	Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3)

Stephen Hemminger wrote:
> The VPD on all devices may not be 32K. Unfortunately, there is no
> generic way to find the size, so this adds a simple API hook
> to reset it.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> ---
>  drivers/pci/access.c |   23 +++++++++++++++++++++++
>  include/linux/pci.h  |    1 +
>  2 files changed, 24 insertions(+)
> 
> --- a/drivers/pci/access.c	2008-09-09 13:57:05.000000000 -0700
> +++ b/drivers/pci/access.c	2008-09-09 13:57:06.000000000 -0700
> @@ -340,6 +340,29 @@ int pci_vpd_pci22_init(struct pci_dev *d
>  }
>  
>  /**
> + * pci_vpd_truncate - Set available Vital Product Data size
> + * @dev:	pci device struct
> + * @size:	available memory in bytes
> + *
> + * Adjust size of available VPD area.
> + */
> +int pci_vpd_truncate(struct pci_dev *dev, size_t size)
> +{
> +	if (!dev->vpd)
> +		return -EINVAL;
> +
> +	/* limited by the access method */
> +	if (size > dev->vpd->len)
> +		return -EINVAL;
> +
> +	dev->vpd->len = size;
> +	dev->vpd->attr->size = size;
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL(pci_vpd_truncate);

What is the initial size?

It seems like a bad idea to start out assuming the max, and reduce once 
a knowledgeable driver appears.

It seems more safe to start out at zero, and let a driver increase it?

That way, by design, you eliminate the possibility (later, if not now) 
of someone assuming that the full 32k can be read as soon as the 
interface is available.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html