netdev - Re: [PATCH 1/9] PCI: vpd handle longer delays in access (rev3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2008 12:54:26 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	netdev@...r.kernel.org, linux-pci@...r.kernel.org,
	Ben Hutchings <bhutchings@...arflare.com>,
	Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH 1/9] PCI: vpd handle longer delays in access (rev3)

On Thu, Sep 25, 2008 at 09:48:52AM -0700, Stephen Hemminger wrote:
> +		if(!cond_resched())

Style nit (did you run checkpatch?)

I think I've commented on the previous versions of this patch enough for
it to be worth adding:

Reviwed-by: Matthew Wilcox <willy@...ux.intel.com>

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html