netdev - [PATCH] skge: Fix skge_set_ring_param() losing error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48DC9E32.503@cn.fujitsu.com>
Date:	Fri, 26 Sep 2008 16:32:50 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	jeff@...zik.org
CC:	Stephen Hemminger <shemminger@...tta.com>,
	NETDEV <netdev@...r.kernel.org>
Subject: [PATCH] skge: Fix skge_set_ring_param() losing error return

From: Wang Chen <wangchen@...fujitsu.com>
Date: Fri, 26 Sep 2008 16:20:32 +0800
Subject: [PATCH] skge: Fix skge_set_ring_param() losing error return

The error return is useful to caller, driver shouldn't miss it.

Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
---
 drivers/net/skge.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index 2e26dce..4c333a1 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -494,7 +494,7 @@ static int skge_set_ring_param(struct net_device *dev,
 			       struct ethtool_ringparam *p)
 {
 	struct skge_port *skge = netdev_priv(dev);
-	int err;
+	int err = 0;
 
 	if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE ||
 	    p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE)
@@ -510,7 +510,7 @@ static int skge_set_ring_param(struct net_device *dev,
 			dev_close(dev);
 	}
 
-	return 0;
+	return err;
 }
 
 static u32 skge_get_msglevel(struct net_device *netdev)
-- 
1.5.5.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html