netdev - Re: Invalid truesize messages since 2.6.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Sep 2008 22:53:35 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Beschorner Daniel <Daniel.Beschorner@...ton.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Invalid truesize messages since 2.6.25

On Fri, 2008-09-26 at 19:53 +0200, Beschorner Daniel wrote:
> I did some more investigations and can reproduce it now in a simple way:
> 
> I take my tg3 device into promiscuous mode and capture ESP packets:
> Just "tcpdump -i eth1 esp" and ping 4 times through the IPSEC tunnel to
> generate ESP traffic, after that dmesg shows
> 
> device eth1 entered promiscuous mode
> SKB BUG: Invalid truesize (336) len=134, sizeof(sk_buff)=208
> SKB BUG: Invalid truesize (336) len=134, sizeof(sk_buff)=208
> SKB BUG: Invalid truesize (336) len=134, sizeof(sk_buff)=208
> SKB BUG: Invalid truesize (336) len=134, sizeof(sk_buff)=208
> device eth1 left promiscuous mode
> 
> Daniel
> 
> ----------
> Since 2.6.25 we rarely see these messages:
> 
> SKB BUG: Invalid truesize (408) len=198, sizeof(sk_buff)=216
> 
> Yesterday I saw it the first time after a runtime of one week with
> 2.6.26.
> The box is web server / IPSEC gateway.
> Obviously nothing seems to be affected by the message but <= 2.6.24 no
> messages appeared.

Commit 3ab224be6d69de912ee21302745ea45a99274dbc, applied between 2.6.24
and 2.6.25, appears to ensure that truesize is checked for all skbs
where previously it was only done for some.  The bug probably already
existed in the ipsec code, which never updates truesize.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html