netdev - Re: [PATCHv2 1/2] [NET] add skb_recycle_check() to enable netdriver skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080929094650.GA26097@xi.wantstofly.org>
Date:	Mon, 29 Sep 2008 11:46:50 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	netdev@...r.kernel.org, Ram.Natarajan@...lex.Com,
	Eric Dumazet <dada1@...mosbay.com>,
	Ashish Karkare <akarkare@...vell.com>,
	Nicolas Pitre <nico@....org>
Subject: Re: [PATCHv2 1/2] [NET] add skb_recycle_check() to enable netdriver skb recycling

On Mon, Sep 29, 2008 at 09:39:31AM +0400, Evgeniy Polyakov wrote:

> Hi Lennert.

Hi Evgeniy,


> > Doesn't it?  It calls skb_release_head_state() (new function), which
> > should do that.
> 
> Argh, you are right, I missed this hunk:
> -/* Free everything but the sk_buff shell. */
> -static void skb_release_all(struct sk_buff *skb)
> +static void skb_release_head_state(struct sk_buff *skb) 
> 
> Patches look good.

Cool, thanks for having a look.

Could you (or anyone else) try this patch on one of your boxes and
see what kind of effect it has on performance?


cheers,
Lennert
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html