netdev - Re: [PATCH] e1000e: release hw semaphore after successfully writing EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48E15B49.4060205@intel.com>
Date:	Mon, 29 Sep 2008 15:48:41 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Arthur Jones <ajones@...erbed.com>
CC:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] e1000e: release hw semaphore after successfully writing
 EEPROM


looks totally valid to me indeed!


Reviewed-by: Auke Kok <auke-jan.h.kok@...el.com>


Auke

Arthur Jones wrote:
> Since e1000e has been existance in linux-2.6, we've
> never released the hardware semaphore after a successful
> write to the SPI EEPROM.  I guess we don't write to
> SPI EEPROM much -- but those few of us that do appreciate
> it when we can later read from the EEPROM without having
> to reboot.
> 
> Found-by: Nick Van Fossen <Nick.VanFossen@...erbed.com>
> Signed-off-by: Arthur Jones <ajones@...erbed.com>
> ---
>  drivers/net/e1000e/lib.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c
> index f1f4e9d..6492107 100644
> --- a/drivers/net/e1000e/lib.c
> +++ b/drivers/net/e1000e/lib.c
> @@ -2012,6 +2012,7 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
>  	}
>  
>  	msleep(10);
> +	nvm->ops.release_nvm(hw);
>  	return 0;
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html