netdev - Re: [net-next PATCH 10/16] Don't lookup the socket if there's a socket attached to the skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081001.075040.135314845.davem@davemloft.net>
Date:	Wed, 01 Oct 2008 07:50:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hidden@....bme.hu
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [net-next PATCH 10/16] Don't lookup the socket if there's a
 socket attached to the skb

From: KOVACS Krisztian <hidden@....bme.hu>
Date: Wed, 01 Oct 2008 16:24:31 +0200

> Use the socket cached in the TPROXY target if it's present.
> 
> Signed-off-by: KOVACS Krisztian <hidden@....bme.hu>

Ok, this starts to get into controversial territory.
:-)

At the very least I think:

1) We should do this unconditionally, and even put
   a "unlikely" there in the test.

2) Actually, the whole operation belongs in a generic
   net/sock.h helper function, and this includes the
   leading if() test.

In the resubmitted patch you can include both UDP
and TCP and the change adding the generic helper all
at once.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html