netdev - Re: [PATCH 1/6] Phonet: transport protocol auto-loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222873275.11272.13.camel@violet.holtmann.net>
Date:	Wed, 01 Oct 2008 17:01:15 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Remi Denis-Courmont <remi.denis-courmont@...ia.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/6] Phonet: transport protocol auto-loading

Hi,

> > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
> > ---
> >  net/phonet/af_phonet.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/net/phonet/af_phonet.c b/net/phonet/af_phonet.c
> > index 1d8df6b..06627d3 100644
> > --- a/net/phonet/af_phonet.c
> > +++ b/net/phonet/af_phonet.c
> > @@ -64,6 +64,11 @@ static int pn_socket_create(struct net *net, struct socket *sock, int protocol)
> >  	}
> >  
> >  	pnp = phonet_proto_get(protocol);
> > +#ifdef CONFIG_KMOD
> > +	if (pnp == NULL
> > +	 && request_module("net-pf-%d-proto-%d", PF_PHONET, protocol) == 0)
> 
> && at the end of previous line, please.
> 
> I wonder if we shouldn't have:
> 
> net_pf_request_module(PF_PHONET, protocol)
> 
> [acme@...pio linux-2.6]$ grep "net-pf-%d-proto-%d" net/*/*.c
> net/ipv4/af_inet.c: request_module("net-pf-%d-proto-%d-type-%d",
> net/ipv4/af_inet.c: request_module("net-pf-%d-proto-%d",
> net/ipv4/inet_diag.c: request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
> net/ipv6/af_inet6.c: request_module("net-pf-%d-proto-%d-type-%d",
> net/ipv6/af_inet6.c: request_module("net-pf-%d-proto-%d",
> net/netlink/af_netlink.c: request_module("net-pf-%d-proto-%d", PF_NETLINK, protocol);
> [acme@...pio linux-2.6]$
> 
> Nah, perhaps not...

maybe it is not such a bad idea. Every protocol seems to have its own
code in it. I am using this:

#if defined(CONFIG_KMOD)
        if (!bt_proto[proto]) {
                request_module("bt-proto-%d", proto);
        }
#endif

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html