netdev - Re: [PATCH 3/3] Phonet: declare headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810011054.52951.remi.denis-courmont@nokia.com>
Date:	Wed, 1 Oct 2008 10:54:52 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext David Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] Phonet: declare headers

On Tuesday 30 September 2008 12:59:57 ext David Miller, you wrote:
> From: Remi Denis-Courmont <remi.denis-courmont@...ia.com>
> Date: Wed, 24 Sep 2008 19:11:40 +0300
>
> > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
>
> Applied.
>
> I took a look and noticed that if_phonet.h needs some top-level
> ifdef multiple inclusion protection.

Oops. Patch follows.

While we're on if_phonet.h, I also wonder what the "right" place for 
phonet_header_ops is... Currently in phonet.ko, any network device driver 
link-depends on the socket stack :-( for two tiny little header_ops 
callbacks. Is that OK? or should it go to core like the Ethernet ops, or be 
inline'd?

Regards,

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html