netdev - Re: [RFC PATCH v6 15/16] cipso: Add support for native local labeling and fixup mapping names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.1.10.0810012003170.6732@tundra.namei.org>
Date:	Wed, 1 Oct 2008 20:09:30 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Paul Moore <paul.moore@...com>
cc:	selinux@...ho.nsa.gov, linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH v6 15/16] cipso: Add support for native local labeling
 and fixup mapping names

On Tue, 16 Sep 2008, Paul Moore wrote:

> +/* Base length of the local tag (non-standard tag).
> + *  Tag definition (may change between kernel versions)
> + *
> + * 0          8          16         24         32
> + * +----------+----------+----------+----------+
> + * | 10000000 | 00001000 | unused (zero fill)  |
> + * +----------+----------+----------+----------+
> + * |   32-bit secid value (host byte order)    |
> + * +----------+----------+----------+----------+
> + *
> + */
> +#define CIPSO_V4_TAG_LOC_BLEN         8
> +

> +static int cipso_v4_gentag_loc(const struct cipso_v4_doi *doi_def,
> +			       const struct netlbl_lsm_secattr *secattr,
> +			       unsigned char *buffer,
> +			       u32 buffer_len)
> +{
> +	if (!(secattr->flags & NETLBL_SECATTR_SECID))
> +		return -EPERM;
> +
> +	buffer[0] = 0x80;
> +	buffer[1] = 0x08;
> +	*(u32 *)&buffer[4] = secattr->attr.secid;
> +
> +	return 8;
> +}

Macros would be nice for these, and why specify zero filling?  (Setting 
and testing that would be wasted cycles, if you enforced it).


- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html