netdev - Re: Bisect'ed BUG in VLAN promisc mode (6c78dcbd47)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0810021835390.8590@tyr.diku.dk>
Date:	Thu, 2 Oct 2008 18:38:21 +0200 (CEST)
From:	Jesper Dangaard Brouer <hawk@...u.dk>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Jesper Dangaard Brouer <jdb@...x.dk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Bisect'ed BUG in VLAN promisc mode (6c78dcbd47)


Here is a quick fix for the bug...
Patrick promised he would do a more clean fix later ;-)

commit 356d09baea53abb7f6a6aabf2264ba104cdb9b5b
Author: Jesper Dangaard Brouer <hawk@...x.dk>
Date:   Thu Oct 2 12:24:19 2008 +0200

     Quick fix from Patrick to solve the VLAN promisc mode bug.

      Bisect'ed BUG in VLAN promisc mode

      All other VLAN interfaces stop working, if a vlan is taken down
      (ifconfig eth1.1025 down) _while_ there is a tcpdump running on that
      interface.

      The problem is a result of promisc mode being removed on the
      real-device (eth1), when the vlan interface is taken down.  This
      should not happen as other vlan devices exists that still need
      promisc mode on the real-device (eth1).

      Need promisc mode because VLAN devices uses another ether address.

     Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 4bf014e..a79daee 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -551,6 +551,8 @@ static void vlan_dev_change_rx_flags(struct net_device *dev, int change)
  {
  	struct net_device *real_dev = vlan_dev_info(dev)->real_dev;

+	if (!netif_running(dev))
+		return;
  	if (change & IFF_ALLMULTI)
  		dev_set_allmulti(real_dev, dev->flags & IFF_ALLMULTI ? 1 : -1);
  	if (change & IFF_PROMISC)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html