netdev - Re: [PATCH 3/6] [NET] dsa: add support for original DSA tagging format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Oct 2008 19:36:01 +0200
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	netdev@...r.kernel.org, Byron Bradley <byron.bbradley@...il.com>,
	Jesper Dangaard Brouer <jdb@...x.dk>,
	Tim Ellis <tim.ellis@....com>,
	Andy Fleming <afleming@...escale.com>,
	Imre Kaloz <kaloz@...nwrt.org>, Nicolas Pitre <nico@....org>,
	Dirk Teurlings <dirk@...xia.nl>,
	Peter van Valderen <p.v.valderen@...il.com>
Subject: Re: [PATCH 3/6] [NET] dsa: add support for original DSA tagging
 format

Please use stronger types..

> +static inline int netdev_uses_dsa_tags(struct net_device *dev)

I would use:
static inline bool netdev_uses_dsa_tags(const struct net_device *dev)


> +int dsa_uses_dsa_tags(void *dsa_ptr);
extern bool dsa_uses_dsa_tags(const struct dsa_switch *dsa);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html