netdev - Re: v2 [PATCH 0/5] dccp: Feature negotiation, Part I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081005.091334.208715265.davem@davemloft.net>
Date:	Sun, 05 Oct 2008 09:13:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: v2 [PATCH 0/5] dccp: Feature negotiation, Part I - Underlying
 data structures

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sat,  4 Oct 2008 11:13:21 +0200

> Please find below the revised patch set, addressing earlier review.

After patch 1:

  CC [M]  net/dccp/feat.o
net/dccp/feat.c:28: warning: ‘dccp_feat_clone_sp_val’ defined but not used

After patch 2:

  CC [M]  net/dccp/feat.o
net/dccp/feat.c:118: warning: ‘dccp_feat_clone_entry’ defined but not used
net/dccp/feat.c:139: warning: ‘dccp_feat_entry_destructor’ defined but not used

After patch 3:

  CC [M]  net/dccp/feat.o
net/dccp/feat.c:118: warning: ‘dccp_feat_clone_entry’ defined but not used
net/dccp/feat.c:157: warning: ‘dccp_feat_list_lookup’ defined but not used
net/dccp/feat.c:208: warning: ‘dccp_feat_push_change’ defined but not used
net/dccp/feat.c:255: warning: ‘dccp_push_empty_confirm’ defined but not used

After patch 4:

  CC [M]  net/dccp/feat.o
net/dccp/feat.c:157: warning: ‘dccp_feat_list_lookup’ defined but not used
net/dccp/feat.c:208: warning: ‘dccp_feat_push_change’ defined but not used
net/dccp/feat.c:255: warning: ‘dccp_push_empty_confirm’ defined but not used

And patch 5 makes no modifications to feat.c so things don't improve.

This can't happen.

You have to split up your patches more intelligently, such that they
are fully bisectable and at each patch point there are no new warnings
or known bugs added.