netdev - [PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Oct 2008 05:57:35 +0800
From:	"Guo-Fu Tseng" <cooldavid@...ldavid.org>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	netdev@...r.kernel.org, Ethan <ethanhsiao@...cron.com>,
	akeemting <akeem@...cron.com>
Subject: [PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix

Dear Jeff, David:

This patch:

    Fix IRQ handle bug when interrupt mode.

    The driver was incorrectly handled and returned IRQ_HANDLED
    while the device is not generating the interrupt.
    It happened due to faulty determination of interrupt status register.

    The patch is also available at:
    http://cooldavid.org/download/jme.net-next-2.6.20081009.2.patch

    Found by: "Ethan" <ethanhsiao@...cron.com>
    Fixed by: "akeemting" <akeem@...cron.com>
    Signed-off-by: Guo-Fu Tseng <cooldavid@...ldavid.org>

diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 635f616..3ab2442 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -1463,7 +1463,7 @@ jme_intr(int irq, void *dev_id)
 	/*
 	 * Check if it's really an interrupt for us
 	 */
-	if (unlikely(intrstat == 0))
+	if (unlikely((intrstat & INTR_ENABLE) == 0))
 		return IRQ_NONE;
 
 	/*

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html