netdev - Re: phylib: Wake PHY state machine on interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20081008.154743.187048380.davem@davemloft.net>
Date:	Wed, 08 Oct 2008 15:47:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tpiepho@...escale.com
CC:	afleming@...escale.com, netdev@...r.kernel.org
Subject: Re: phylib: Wake PHY state machine on interrupt


With a minor coding style fix, I've applied your patch
as below.  Thanks.

commit 0acb28396728f42b6b1553c85d27c37513796043
Author: Trent Piepho <tpiepho@...escale.com>
Date:   Wed Oct 8 15:46:57 2008 -0700

    phylib: Wake PHY state machine on interrupt
    
    This way the phy layer will respond to a change in phy state immediately,
    instead of up to one second later when the state machine timer runs.
    
    Signed-off-by: Trent Piepho <tpiepho@...escale.com>
    Acked-by: Andy Fleming <afleming@...escale.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 0433fcd..20cc82c 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -729,6 +729,12 @@ static void phy_change(struct work_struct *work)
 	if (err)
 		goto irq_enable_err;
 
+	/* Stop timer and run the state queue now.  The work function for
+	 * state_queue will start the timer up again.
+	 */
+	del_timer(&phydev->phy_timer);
+	schedule_work(&phydev->state_queue);
+
 	return;
 
 irq_enable_err:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html