netdev - Re: [PATCH net-next 10/14] ipv6: ICMP6MSGIN_INC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Oct 2008 11:23:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dlstevens@...ibm.com
Cc:	den@...nvz.org, benjamin.thery@...l.net, dlezcano@...ibm.com,
	netdev@...r.kernel.org, netdev-owner@...r.kernel.org,
	xemul@...nvz.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 10/14] ipv6: ICMP6MSGIN_INC_STATS is not used

From: David Stevens <dlstevens@...ibm.com>
Date: Wed, 8 Oct 2008 10:37:25 -0700

> This is there to parallel the definitions for other stats
> macros. I don't think it should be removed, since it's
> part of the standard interface for incrementing counters.
> If someone has a need to increment it without, say, _BH,
> I wouldn't want them to have to come up with it from
> scratch again...
> 
> It's cost is the two lines of code it takes, but you could
> consider it "documentation" for any future users that
> want that variant.

I disagree.

It's more work to change interfaces globally like these namespace
guys frequently have to, if we leave unused interfaces around.

The changelog history clearly contains the old macro so it can
be resurrected properly, and folks such as you or myself can
point this out if someone adds an improper reimplementation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html