netdev - Re: [PATCH net-yourcall] tcp: fix length used for checksum in a reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081008.113442.193702738.davem@davemloft.net>
Date:	Wed, 08 Oct 2008 11:34:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	agl@...erialviolet.org, yoshfuji@...ux-ipv6.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-yourcall] tcp: fix length used for checksum in a
 reset

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Wed, 8 Oct 2008 14:45:35 +0300 (EEST)

> 
> While looking for some common code I came across difference
> in checksum calculation between tcp_v6_send_(reset|ack) I
> couldn't explain. I checked both v4 and v6 and found out that
> both seem to have the same "feature". I couldn't find anything
> in rfc nor anywhere else which would state that md5 option
> should be ignored like it was in case of reset so I came to
> a conclusion that this is probably a genuine bug. I suspect
> that addition of md5 just was fooled by the excessive
> copy-paste code in those functions and the reset part was
> never tested well enough to find out the problem.
> 
> I don't see any urge to put this to net-2.6 right before
> 2.6.27 considering it has been broken for ages without anybody
> noticing (considering the Linus' new always-been-like-that-
> but-now-just-enforced rule :-)).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Thanks for finding and fixing this bug, applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html