netdev - Re: [PATCH net-next 2/6] bnx2: Check netif_running() in all ethtool operations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081009.142604.14627439.davem@davemloft.net>
Date:	Thu, 09 Oct 2008 14:26:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, benli@...adcom.com, mcarlson@...adcom.com
Subject: Re: [PATCH net-next 2/6] bnx2: Check netif_running() in all
 ethtool operations.

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 09 Oct 2008 13:59:00 -0700

> 
> On Thu, 2008-10-09 at 12:22 -0700, David Miller wrote:
> > From: "Michael Chan" <mchan@...adcom.com>
> > Date: Thu,  9 Oct 2008 10:16:04 -0700
> > 
> > > We need to check netif_running() state in most ethtool operations
> > > and properly handle the !netif_running() state where the chip is
> > > in an uninitailzed state or low power state that may not accept
> > > any MMIO.
> > >
> > > Signed-off-by: Michael Chan <mchan@...adcom.com>
> > > Signed-off-by: Benjamin Li <benli@...adcom.com>
> > > Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> > 
> > Applied, but I wonder if this will trip people up who invoke
> > ethtool to set a specific link setting before bringing the
> > device up?
> > 
> 
> ethtool -s is not affected by the patch and will continue to work
> whether the device is up or down.  The patch affects operations such as
> reading/writing NVRAM, restart autoneg, etc, that require the device to
> be up.

Thanks for the clarification.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html