netdev - Re: [NET-NEXT PATCH 2/2] e1000: don't generate bad checksums for tcp packets with 0 csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081009.142945.135108546.davem@davemloft.net>
Date:	Thu, 09 Oct 2008 14:29:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, david.graham@...el.com,
	jesse.brandeburg@...el.com
Subject: Re: [NET-NEXT PATCH 2/2] e1000: don't generate bad checksums for
 tcp packets with 0 csum

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 09 Oct 2008 09:58:52 -0700

> When offloading transmit checksums only, the driver was not
> correctly configuring the hardware to handle the case of a zero
> checksum.  For UDP the correct behavior is to leave it alone, but
> for tcp the checksum must be changed from 0x0000 to 0xFFFF.  The
> hardware takes care of this case but only if it is told the
> packet is tcp.
> 
> same patch as e1000e
> 
> Signed-off-by: Dave Graham <david.graham@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html