netdev - Re: small design problem with hso driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081009103259.066cc94a@lxorguk.ukuu.org.uk>
Date:	Thu, 9 Oct 2008 10:32:59 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Denis Joseph Barrow <D.Barow@...ion.com>
Cc:	Greg KH <greg@...ah.com>,
	Linux USB kernel mailing list <linux-usb@...r.kernel.org>,
	Linux netdev Mailing list <netdev@...r.kernel.org>
Subject: Re: small design problem with hso driver

> Surely if the driver returns an error code on hso_serial_open
> hso_serial_close shouldn't be called
> or have I a complete misunderstanding
> of char driver semantics.

Generally yes that would be sane. The tty layer has always called the
close method of drivers on a failed open and the drivers are all written
assuming that.

It would be nice to change but there are far bigger fish to fry.

Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html