netdev - RE: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36D9DB17C6DE9E40B059440DB8D95F520667243B@orsmsx418.amr.corp.intel.com>
Date:	Fri, 10 Oct 2008 10:48:55 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Patrick McHardy" <kaber@...sh.net>,
	"Linux Netdev List" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>
Cc:	<e1000-devel@...ts.sourceforge.net>
Subject: RE: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload

Patrick McHardy wrote:
> Patrick McHardy wrote:
>> This patch changes e1000 to set vlan_features so TSO and CSUM
>> offload can be used by VLAN devices, similar as with the other Intel
>> drivers. 
>> 
>> Only RFC because I don't know whether there is buggy hardware
>> that doesn't support this properly, but feel free to apply in
>> case there isn't.
> 
> I never received a response to this. Any comments?

Sorry to delay the reply, the only one that stands out to me as a
possible problem with the devices that e1000 still supports is the
NETIF_F_TSO6.

I know that some of our older parts like 82544 don't support TSO6.

As I read: these should work:
82546GB/EB, 82545GM/EM, 82541(PI/GI/EI), 82541ER, 82547GI/EI, and
82540EP/EM

These parts should all work (at least as advertised in the software
reference manual available at
http://superb-east.dl.sourceforge.net/sourceforge/e1000/OpenSDM_8254x-37
.pdf)

with the exception of 82544 GC/EI

So as it stands your patch will not work on some hardware.  Also, would
we need to hook the ethtool methods such that if a user disables TSO it
will disable vlan_features(TSO) as well?

Jesse



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html