netdev - Re: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 12:09:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	jesse.brandeburg@...el.com, kaber@...sh.net,
	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	bruce.w.allan@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM
 offload

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 10 Oct 2008 18:59:36 +0100

> On Fri, 2008-10-10 at 10:48 -0700, Brandeburg, Jesse wrote:
> > Patrick McHardy wrote:
> > > Patrick McHardy wrote:
> > >> This patch changes e1000 to set vlan_features so TSO and CSUM
> > >> offload can be used by VLAN devices, similar as with the other Intel
> > >> drivers. 
> > >> 
> > >> Only RFC because I don't know whether there is buggy hardware
> > >> that doesn't support this properly, but feel free to apply in
> > >> case there isn't.
> > > 
> > > I never received a response to this. Any comments?
> > 
> > Sorry to delay the reply, the only one that stands out to me as a
> > possible problem with the devices that e1000 still supports is the
> > NETIF_F_TSO6.
> 
> vlan_features is a mask for features.  So long as all parts that do
> support TSO-IPv6 also support it for VLAN-tagged packets, it should be
> safe to set NETIF_F_TSO6 in vlan_features unconditionally.

Right, it's an additional mask which gets and'd with the normal
device feature bits.

Jesse, any objections, given that?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html