netdev - [PATCH] [stable 2.6.27.y] don't take the mdio_lock in atl1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081011100501.7ff818ce@osprey.hogchain.net>
Date:	Sat, 11 Oct 2008 10:05:01 -0500
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	stable@...nel.org
Cc:	Matthew Wilcox <willy@...ux.intel.com>,
	Jeff Garzik <jgarzik@...hat.com>,
	Chris Snook <csnook@...hat.com>,
	Jie Yang <jie.yang@...eros.com>, netdev@...r.kernel.org,
	Jay Cliburn <jcliburn@...il.com>, nm127@...email.hu,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] [stable 2.6.27.y] don't take the mdio_lock in atl1e_probe

From: Matthew Wilcox <matthew@....cx>

Upstream commit: f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd

This fixes bug 11736.

http://marc.info/?l=linux-netdev&m=122367387219316&w=2

Lockdep warns about the mdio_lock taken with interrupts enabled then
later taken from interrupt context.  Initially, I considered changing
these to spin_lock_irq/spin_unlock_irq, but then I looked at
atl1e_phy_init() and saw that it calls msleep().  Sleeping while
holding a spinlock is not allowed either.

In the probe path, we haven't registered the interrupt handler, so
it can't poke at this card yet.  It's before we call register_netdev(),
so I don't think any other threads can reach this card either.  If I'm
right, we don't need a spinlock at all.

Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
---

Resending with correct -stable email address.

 drivers/net/atl1e/atl1e_main.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/atl1e/atl1e_main.c
b/drivers/net/atl1e/atl1e_main.c index 7685b99..9b60352 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -2390,9 +2390,7 @@ static int __devinit atl1e_probe(struct pci_dev
*pdev, }

        /* Init GPHY as early as possible due to power saving issue  */
-       spin_lock(&adapter->mdio_lock);
        atl1e_phy_init(&adapter->hw);
-       spin_unlock(&adapter->mdio_lock);
        /* reset the controller to
         * put the device in a known good starting state */
        err = atl1e_reset_hw(&adapter->hw);
--
1.5.5.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html