netdev - Re: [PATCH 1/1 2.6.28] cxgb3 - add one check in interrupt routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081011.122919.61290776.davem@davemloft.net>
Date:	Sat, 11 Oct 2008 12:29:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wendyx@...ibm.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, wenxiong@...ibm.com
Subject: Re: [PATCH 1/1 2.6.28] cxgb3 - add one check in interrupt routine

From: wendy xiong <wendyx@...ibm.com>
Date: Fri, 10 Oct 2008 15:48:48 -0500

> Hi Jeff,
> 
> We are submitting a patch to do the test before accessing A_PL_CLI register in interrupt routine for inclusion in 2.6.28, 
> as follows:

First, missing Signed-off-by:

Second, this is recidulious.

Every single interrupt we're going to check this error state value.  That's excessive,
and this is a performance critical fast path.

I do not want to see this begin to be a trend in the drivers, so I'm rejecting this
right now before it starts to spread.

If you want to handle this case, do something like quiesce the interrupt handler and
disable it when an error is detected.  That kind of scheme, at worst, will have the
same kinds of races that this silly test does.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html