netdev - [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Oct 2008 00:06:15 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	linux-driver@...gic.com
Cc:	netdev@...r.kernel.org, ron.mercer@...gic.com,
	linux-ia64@...r.kernel.org
Subject: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit
	compile failure

QLGE driver only supports 4k, 8k, and 64k pages.
Default page size on ia64 is 16k. Compile fails with:
drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function)

Patch below makes the cause of the compile failure obvious.
(Better would be to support 16k pages but I don't have the HW or interest.)

Signed-off-by: Grant Grundler <grundler@...isc-linux.org>


diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index c37ea43..cf68503 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -60,6 +60,8 @@
 #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
 #elif (PAGE_SHIFT == 16)	/* 64k pages */
 #define TX_DESC_PER_OAL 0
+#else
+#error QLGE Driver only supports 4k, 8k, or 64k CPU page size.
 #endif
 
 #define DB_PAGE_SIZE 4096
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html