netdev - [PATCH] de2104x: wrong MAC address fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081013180459.GA3389@tuba>
Date:	Mon, 13 Oct 2008 20:04:59 +0200
From:	Martin Langer <martin-langer@....de>
To:	netdev@...r.kernel.org
Subject: [PATCH] de2104x: wrong MAC address fix

The de2104x returns sometimes a wrong MAC address. The wrong one is
like the original one, but it comes with an one byte shift. I found
this bug on an older alpha ev5 cpu. More details are available in Gentoo
bugreport #240718.

It seems the hardware is sometimes a little bit too slow for an
immediate access. This patch solves the problem by introducing a small
udelay.

Signed-off-by: Martin Langer <martin-langer@....de>

--- drivers/net/tulip/de2104x.c_ORIGINAL	2008-10-10 00:13:53.000000000 +0200
+++ drivers/net/tulip/de2104x.c	2008-10-11 19:04:32.000000000 +0200
@@ -1689,6 +1689,7 @@
 	unsigned i;

 	dw32 (ROMCmd, 0);	/* Reset the pointer with a dummy write. */
+	udelay(5);

 	for (i = 0; i < 6; i++) {
 		int value, boguscnt = 100000;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html