netdev - Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081014025329.GA25397@susedev.qlogic.org>
Date:	Mon, 13 Oct 2008 19:53:29 -0700
From:	Ron Mercer <ron.mercer@...gic.com>
To:	David Miller <davem@...emloft.net>
Cc:	matthew@....cx, grundler@...isc-linux.org, linux-driver@...gic.com,
	netdev@...r.kernel.org, linux-ia64@...r.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure

On Mon, Oct 13, 2008 at 07:31:53PM -0700, David Miller wrote:
> From: Matthew Wilcox <matthew@....cx>
> Date: Mon, 13 Oct 2008 20:19:02 -0600
> 
> > On Mon, Oct 13, 2008 at 07:03:45PM -0700, David Miller wrote:
> > > From: Ron Mercer <ron.mercer@...gic.com>
> > > Date: Mon, 13 Oct 2008 18:54:55 -0700
> > > 
> > > > This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list.  For page sizes larger than 8k the max frags is satisfied by the original TX control block.
> > > 
> > > I'm not applying this.  I _explicitly_ said I would not apply a
> > > solution like this.
> > > 
> > > I waited for you guys all day for this?!?!
> > > 
> > > We need to find a way to make this a Kconfig dependency.
> > > 
> > > Build failures are absolutely unacceptable.
> > 
> > Um, Dave, I think you misread his patch.
> > 
> > All it does it make the '64k case' the 'every other size case'.  There's
> > no build failure with Ron's patch.
> 
> Thanks for the correction, I'll look at this again :)

My explanation might not have been very good.  What I was trying to say
is that the macro in question determines the size of a scatter/gathter
list that is external to the TX descriptor.  The size is based on
MAX_SKB_FRAGS and PAGE_SIZE.  When PAGE_SIZE is larger than 8k I don't
need the external scatter/gather list because all frags will fit in the
native TX descriptor.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html