| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <386072610810140150t4c960a17yf7bfd6032b8710f2@mail.gmail.com>
Date: Tue, 14 Oct 2008 16:50:20 +0800
From: "Bryan Wu" <cooloney@...nel.org>
To: "Stephen Hemminger" <shemminger@...tta.com>
Cc: ben@...tec.co.uk, s.hauer@...gutronix.de, jeff@...zik.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"Javier Herrero" <jherrero@...istemas.es>
Subject: Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin
On Mon, Oct 13, 2008 at 8:41 PM, Stephen Hemminger
<shemminger@...tta.com> wrote:
> On Mon, 13 Oct 2008 17:10:09 +0800
> Bryan Wu <cooloney@...nel.org> wrote:
>
>> From: Javier Herrero <jherrero@...istemas.es>
>>
>> Signed-off-by: Javier Herrero <jherrero@...istemas.es>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> ---
>> drivers/net/dm9000.c | 12 ++++++------
>> 1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
>> index f42c23f..c4737ca 100644
>> --- a/drivers/net/dm9000.c
>> +++ b/drivers/net/dm9000.c
>> @@ -188,35 +188,35 @@ iow(board_info_t * db, int reg, int value)
>>
>> static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count)
>> {
>> - writesb(reg, data, count);
>> + writesb((int)reg, data, count);
>> }
>
> You lose the sparse checking for misuse by doing this.
>
> Why not this instead?
>
>
> --- a/drivers/net/dm9000.c 2008-10-13 05:29:15.000000000 -0700
> +++ b/drivers/net/dm9000.c 2008-10-13 05:40:13.000000000 -0700
> @@ -47,14 +47,6 @@
> #define CARDNAME "dm9000"
> #define DRV_VERSION "1.31"
>
> -#ifdef CONFIG_BLACKFIN
> -#define readsb insb
> -#define readsw insw
> -#define readsl insl
> -#define writesb outsb
> -#define writesw outsw
> -#define writesl outsl
> -#endif
>
> /*
> * Transmit timeout, default 5 seconds.
> @@ -185,7 +177,40 @@ iow(board_info_t * db, int reg, int valu
> }
>
> /* routines for sending block to chip */
> +#ifdef CONFIG_BLACKFIN
> +static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count)
> +{
> + outsb((unsigned long)reg, data, count);
> +}
>
I added readsl/writesl to blackfin arch, so we don't need to mess up
the common DM9000 netdev driver here.
-Bryan
> +static void dm9000_outblk_16bit(void __iomem *reg, void *data, int count)
> +{
> + outsw((unsigned long)reg, data, (count+1) >> 1);
> +}
> +
> +static void dm9000_outblk_32bit(void __iomem *reg, void *data, int count)
> +{
> + outsl((unsigned long)reg, data, (count+3) >> 2);
> +}
> +
> +/* input block from chip to memory */
> +
> +static void dm9000_inblk_8bit(void __iomem *reg, void *data, int count)
> +{
> + insb((unsigned long)reg, data, count);
> +}
> +
> +
> +static void dm9000_inblk_16bit(void __iomem *reg, void *data, int count)
> +{
> + insw((unsigned long)reg, data, (count+1) >> 1);
> +}
> +
> +static void dm9000_inblk_32bit(void __iomem *reg, void *data, int count)
> +{
> + insl((unsigned long)reg, data, (count+3) >> 2);
> +}
> +#else
> static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count)
> {
> writesb(reg, data, count);
> @@ -218,6 +243,7 @@ static void dm9000_inblk_32bit(void __io
> {
> readsl(reg, data, (count+3) >> 2);
> }
> +#endif
>
> /* dump block from chip to null */
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists