netdev - Re: decnet: Fix complier warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2008 13:40:35 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	davem@...hat.com, netdev@...r.kernel.org,
	Christine Caulfield <ccaulfie@...hat.com>
Subject: Re: decnet: Fix complier warning

Hi,

On Wed, 2008-10-15 at 13:37 +0100, Ben Hutchings wrote:
> On Wed, 2008-10-15 at 13:19 +0100, Steven Whitehouse wrote:
> > This patch fixes a warning seen during compiling dn_dev.c. The warning is harmless
> > since we know that the structure length in question is less than 2^32 bytes, but
> > this fixes it anyway.
> > 
> > Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
> > Cc: Christine Caulfield <ccaulfie@...hat.com>
> > 
> > diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
> > index 2f0ac3c..d9bc69c 100644
> > --- a/net/decnet/dn_dev.c
> > +++ b/net/decnet/dn_dev.c
> > @@ -152,7 +152,7 @@ static struct dn_dev_parms dn_dev_list[] =  {
> >  
> >  #define DN_DEV_LIST_SIZE ARRAY_SIZE(dn_dev_list)
> >  
> > -#define DN_DEV_PARMS_OFFSET(x) ((int) ((char *) &((struct dn_dev_parms *)0)->x))
> > +#define DN_DEV_PARMS_OFFSET(x) ((long) ((char *) &((struct dn_dev_parms *)0)->x))
> >  
> >  #ifdef CONFIG_SYSCTL
> >  
> 
> Or you could make this use offsetof().  Daring, I know, it's only been a
> standard macro for nearly 20 years.
> 
> Ben.
> 
Yes, thats true. The whole set of code is rather suspect to say the
least and I was going for the minimal fix. Its a long time since I last
looked at this code so I don't remember exactly why it was done in that
way,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html